rawlinp commented on a change in pull request #1908: Changes for Backup Edge
Cache Group
URL:
https://github.com/apache/incubator-trafficcontrol/pull/1908#discussion_r172944013
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
##########
@@ -279,7 +282,11 @@ public Geolocation getLocation(final String clientIP,
final DeliveryService deli
track.setResult(ResultType.MISS);
track.setResultDetails(ResultDetails.DS_CZ_ONLY);
}
- } else {
+ } else if ((useDeep) || (networkNode != null &&
networkNode.isUseClosest()) || (networkNode == null)) {
Review comment:
I think this can remain a simple `else` if the logic in my comment above is
implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
