rawlinp commented on a change in pull request #1908: Changes for Backup Edge 
Cache Group
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1908#discussion_r172938260
 
 

 ##########
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
 ##########
 @@ -345,8 +352,9 @@ public DNSRouteResult route(final DNSRequest request, 
final Track track) throws
                        return result;
                }
 
-               final CacheLocation cacheLocation = 
getCoverageZoneCacheLocation(request.getClientIP(), ds);
+               final CacheLocation cacheLocation = 
getCoverageZoneCacheLocation(request.getClientIP(), ds, track, false);
 
 Review comment:
   is it possible to change the method signature to have this be 
`getCoverageZoneCacheLocation(request.getClientIP(), ds, track);` so that we're 
not passing `useDeep` explicitly as false? `useDeep` should default to false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to