[
https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369788#comment-14369788
]
ASF GitHub Bot commented on TS-2157:
------------------------------------
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26779726
--- Diff: proxy/http/HttpSM.cc ---
@@ -549,8 +549,9 @@ HttpSM::attach_client_session(HttpClientSession *
client_vc, IOBufferReader * bu
NetVConnection* netvc = client_vc->get_netvc();
- ats_ip_copy(&t_state.client_info.addr, netvc->get_remote_addr());
- t_state.client_info.port = netvc->get_local_port();
+ ats_ip_copy(&t_state.client_info.src_addr, netvc->get_remote_addr());
+ ats_ip_copy(&t_state.client_info.dst_addr, netvc->get_local_addr());
+ t_state.client_info.dst_addr.port() = netvc->get_local_port();
--- End diff --
client_info is the only one where we initialize both sides of the
connection info right now because it's the only one where the port member had a
different meaning before--should we init both sides for server_info? where
would be best to do that/does it make sense?
> Replace "addr" with appropriate "src_addr" and "dst_addr" in
> ConnectionAttributes
> ---------------------------------------------------------------------------------
>
> Key: TS-2157
> URL: https://issues.apache.org/jira/browse/TS-2157
> Project: Traffic Server
> Issue Type: New Feature
> Components: Network
> Reporter: Leif Hedstrom
> Assignee: Eric Schwartz
> Fix For: 6.0.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint)
> for each connection. In addition, we ought to be able to remove the "port"
> member from ConnectionAttributes as well, and its convoluted and overloaded
> semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the
> port information as necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
