[
https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369795#comment-14369795
]
ASF GitHub Bot commented on TS-2157:
------------------------------------
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26780171
--- Diff: proxy/http/HttpTransact.h ---
@@ -698,16 +698,11 @@ class HttpTransact
bool dns_round_robin;
TransferEncoding_t transfer_encoding;
- IpEndpoint addr; // replaces 'ip' field
-
- // port to connect to, except for client
- // connection where it is port on proxy
- // that client connected to.
- // This field is managed separately from the port
- // part of 'addr' above as in various cases the two
- // are set/manipulated independently and things are
- // clearer this way.
- uint16_t port; // host order.
+ // TS-2157 Replace addr with src_addr dst_addr
+ // also replaces port field
+ IpEndpoint src_addr;
+ IpEndpoint dst_addr;
+
--- End diff --
note that uint16_t port is dropped. port is instead stored inside the
IpEndpoint struct.
> Replace "addr" with appropriate "src_addr" and "dst_addr" in
> ConnectionAttributes
> ---------------------------------------------------------------------------------
>
> Key: TS-2157
> URL: https://issues.apache.org/jira/browse/TS-2157
> Project: Traffic Server
> Issue Type: New Feature
> Components: Network
> Reporter: Leif Hedstrom
> Assignee: Eric Schwartz
> Fix For: 6.0.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint)
> for each connection. In addition, we ought to be able to remove the "port"
> member from ConnectionAttributes as well, and its convoluted and overloaded
> semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the
> port information as necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
