[
https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369791#comment-14369791
]
ASF GitHub Bot commented on TS-2157:
------------------------------------
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26779989
--- Diff: proxy/http/HttpTransact.cc ---
@@ -288,6 +288,8 @@
find_server_and_update_current_info(HttpTransact::State* s)
/* fall through */
default:
update_current_info(&s->current, &s->server_info,
HttpTransact::ORIGIN_SERVER, (s->current.attempts)++);
+ // TS-2157 must update port here because we know struct has been set
+ s->current.server->dst_addr.port() =
s->hdr_info.server_request.port_get();
--- End diff --
am very open to suggestions if anyone can think of a better way of doing
this
> Replace "addr" with appropriate "src_addr" and "dst_addr" in
> ConnectionAttributes
> ---------------------------------------------------------------------------------
>
> Key: TS-2157
> URL: https://issues.apache.org/jira/browse/TS-2157
> Project: Traffic Server
> Issue Type: New Feature
> Components: Network
> Reporter: Leif Hedstrom
> Assignee: Eric Schwartz
> Fix For: 6.0.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint)
> for each connection. In addition, we ought to be able to remove the "port"
> member from ConnectionAttributes as well, and its convoluted and overloaded
> semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the
> port information as necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
