[
https://issues.apache.org/jira/browse/TS-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136086#comment-15136086
]
ASF GitHub Bot commented on TS-4176:
------------------------------------
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180907419
Yes, we can be fairly sure it doesn't (break anything), because:
a) we've added functionality not changing the way it worked before (bug
aside). So, if content-type, md5, and matrix params are not present, it should
behave as before.
b) These fields not being present is actually the most common situation -
so we've actually verified that the old functionality remains as is, because in
most cases, md5, content-type, and matrix params are not used in GET requests.
The only caveat I can think of is using virtual host, which I am not and
can't (very easily). Based on the code though, that little logic (prepending
the host) seems unchanged by this PR.
This code is deployed in "production" right now in our aws region, and
being tested routinely.
> s3_auth plugin matrix parameters support
> ----------------------------------------
>
> Key: TS-4176
> URL: https://issues.apache.org/jira/browse/TS-4176
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Roberto Guimaraes
> Assignee: Kit Chan
> Fix For: 6.2.0
>
>
> Matrix parameters, whenever present, must be included in the HMAC calculation
> of authentication.
> Also, even though Content-Type isn't typically included in GET requests, if
> present (bug) it will break the authentication.
> We will fix these here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
