[
https://issues.apache.org/jira/browse/TS-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137839#comment-15137839
]
ASF GitHub Bot commented on TS-4176:
------------------------------------
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181594755
Couple of things on that last patch:
1) You have to run clang-format over the code, I'm fairly certain we would
never indent like this:
if (con_md5) TSDebug(PLUGIN_NAME, "%.*s", con_md5_len, con_md5);
2) Must we really introduce usage of std::string left("/"); ?? I guess this
is inside a debug if() check, it's not a huge deal, but I cringe when I see
std::string :-).
> s3_auth plugin matrix parameters support
> ----------------------------------------
>
> Key: TS-4176
> URL: https://issues.apache.org/jira/browse/TS-4176
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Roberto Guimaraes
> Assignee: Kit Chan
> Fix For: 6.2.0
>
>
> Matrix parameters, whenever present, must be included in the HMAC calculation
> of authentication.
> Also, even though Content-Type isn't typically included in GET requests, if
> present (bug) it will break the authentication.
> We will fix these here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
