[
https://issues.apache.org/jira/browse/TS-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150910#comment-15150910
]
ASF GitHub Bot commented on TS-4176:
------------------------------------
Github user gtenev commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-185330773
- Reviewed and tested the patch and it looks OK.
- Verified that it does not break backward compatibility, tested end-to-end
against S3 with both virtual-hosted-style and path-style methods.
- Tested the Content-Type and Content-MD5 features and they worked
correctly.
- Tested the matrix parameters feature, did not do end-to-end against S3
since we don't use matrix parameters in our setup but verified that the matrix
parameters are added correctly to the CanonicalizedResource in the StringToSign
and that the Authorization header is calculated correctly.
> s3_auth plugin matrix parameters support
> ----------------------------------------
>
> Key: TS-4176
> URL: https://issues.apache.org/jira/browse/TS-4176
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Roberto Guimaraes
> Assignee: Kit Chan
> Fix For: 6.2.0
>
>
> Matrix parameters, whenever present, must be included in the HMAC calculation
> of authentication.
> Also, even though Content-Type isn't typically included in GET requests, if
> present (bug) it will break the authentication.
> We will fix these here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
