[
https://issues.apache.org/jira/browse/TS-4664?focusedWorklogId=25539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25539
]
ASF GitHub Bot logged work on TS-4664:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/16 00:23
Start Date: 17/Jul/16 00:23
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/801#discussion_r71073791
--- Diff: proxy/ProxyClientSession.cc ---
@@ -142,7 +141,9 @@ ProxyClientSession::do_api_callout(TSHttpHookID id)
this->api_current = NULL;
if (this->hooks_on && this->has_hooks()) {
- SET_HANDLER(&ProxyClientSession::state_api_callout);
+ if (!this->handler) {
--- End diff --
I'm not sure about this. The state of the handler doesn't seem to be
well-defined at this point. HTTP2 sets the handler in ``start()``, for example.
Issue Time Tracking
-------------------
Worklog Id: (was: 25539)
Time Spent: 40m (was: 0.5h)
> Crash due to separate event handlers for IO events and plugin events for
> ClientSession
> --------------------------------------------------------------------------------------
>
> Key: TS-4664
> URL: https://issues.apache.org/jira/browse/TS-4664
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Found while tracking TS-4507 and original fix on that branch.
> Cleaned up handling regular events at the same time as plugin events. The
> original code relied on the subclasses overriding handle_api_event to handle
> the regular events, but the handler only handled the TIMEOUT event. Changed
> that to augment the subclasses' main event handler to call out to
> state_api_callout in the event of the plugin events.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
