[
https://issues.apache.org/jira/browse/TS-4664?focusedWorklogId=25672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25672
]
ASF GitHub Bot logged work on TS-4664:
--------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/16 03:00
Start Date: 19/Jul/16 03:00
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/801
Ah. The invariant is that you are not supposed to be getting IO events
during session hook processing. Maybe the fact that this is happening is the
root cause of the bug?
This change adds knowledge of the hook processing into more event handlers
which seems worse to me. The logic now needs to be maintained and understood in
more places. The original goal of the base class here was to remove the
duplication of session hook processing.
Issue Time Tracking
-------------------
Worklog Id: (was: 25672)
Time Spent: 2h (was: 1h 50m)
> Crash due to separate event handlers for IO events and plugin events for
> ClientSession
> --------------------------------------------------------------------------------------
>
> Key: TS-4664
> URL: https://issues.apache.org/jira/browse/TS-4664
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Found while tracking TS-4507 and original fix on that branch.
> Cleaned up handling regular events at the same time as plugin events. The
> original code relied on the subclasses overriding handle_api_event to handle
> the regular events, but the handler only handled the TIMEOUT event. Changed
> that to augment the subclasses' main event handler to call out to
> state_api_callout in the event of the plugin events.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
