[
https://issues.apache.org/jira/browse/TS-4664?focusedWorklogId=25614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25614
]
ASF GitHub Bot logged work on TS-4664:
--------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/16 05:57
Start Date: 18/Jul/16 05:57
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/801
I had to re-read this code to refresh my memory on how this works. I think
that the invariant that the ``ProxyClientSession`` requires is that the API
hooks are the first and last operations performed on the session. This means
that the handler must be ``NULL`` when delivering the ``SSN_START`` event
(which is always true because this is done before ``start()``). It also means
that we should not have to worry about other event handlers when delivering
``SSN_CLOSE``, because the only ``destroy()`` happens after this.
I agree that ``state_api_callout`` should not be virtual (it should be
private).
Issue Time Tracking
-------------------
Worklog Id: (was: 25614)
Time Spent: 1h (was: 50m)
> Crash due to separate event handlers for IO events and plugin events for
> ClientSession
> --------------------------------------------------------------------------------------
>
> Key: TS-4664
> URL: https://issues.apache.org/jira/browse/TS-4664
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Found while tracking TS-4507 and original fix on that branch.
> Cleaned up handling regular events at the same time as plugin events. The
> original code relied on the subclasses overriding handle_api_event to handle
> the regular events, but the handler only handled the TIMEOUT event. Changed
> that to augment the subclasses' main event handler to call out to
> state_api_callout in the event of the plugin events.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
