Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/825#discussion_r72022413
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
virtual bool allow_half_open() const = 0;
- virtual const char *get_protocol_string() const = 0;
+ virtual const char *
--- End diff --
Would it make sense to have these getter's take an (optional) argument to
get the length as well? I noticed that later, in e.g. logging, we have to do
strlen() on these static strings every time we use, which seems a bit wasteful,
no? Maybe something like
get_protocol_string(int *len = NULL);
?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
