Github user masaori335 commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/825#discussion_r72222506
  
    --- Diff: proxy/ProxyClientTransaction.h ---
    @@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
     
       virtual bool allow_half_open() const = 0;
     
    -  virtual const char *get_protocol_string() const = 0;
    +  virtual const char *
    --- End diff --
    
    Currently plugins can not set client_protocol of HttpSM ( which is going to 
be added by this patch ), but it could be set in the future. And it also has 
consistency for other stats in HttpSM (e.g. client_sec_protocol, 
client_cipher_suite). So, let's leave it string.
    
    I'll file a new tickets for optimization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to