Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/825#discussion_r72179084
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
virtual bool allow_half_open() const = 0;
- virtual const char *get_protocol_string() const = 0;
+ virtual const char *
--- End diff --
Yeah, it's better to reduce strlen calls. I start thinking about returning
int or enum from here (something like `TS_SSN_PROTOCOL_INDEX_HTTP_x_x`) and
convert it to string in logging phase.
Do we really need to return string at here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
