Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/823
We don't really use event return values outside of event handlers, so if we
return a failure from ``accept()``, it should just be a ``bool``.
Originally, the contract for ``SessionAccept::accept()`` was that it always
consumed its arguments. This means that it should be responsible for releasing
the ``MIOBuffer`` on failure. With your proposal, the caller deleted the buffer
but the callee closes the vc. Both the vc and the buffer should be treated
consistently, so either enforce the original contract, or delete any allocated
buffers in the leaf handlers when they fail (updating the comments that
describe the calling contract).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
