Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/823
@jpeach agree with u to return bool from SessionAccept::accept().
SessionAccept did not consume any parameters, It is just transfer
parameters to ClientSession.
as your said "Both the vc and the buffer should be treated consistently",
I'm prefer to move do_io_close() and free MIOBuffer from SessionAccept to
ProtocolProbeTrampoline.
Just return false if ipallow check fails in XXXSessionAccept::accept().
Then, the NetVC and MIOBuffer will be close&free in ProtocolProbeTrampoline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
