Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/823#discussion_r75058577
--- Diff: iocore/net/I_SessionAccept.h ---
@@ -29,12 +29,40 @@
struct AclRecord;
+/**
+ The base class SessionAccept can not be used directly.
+ The inherited class of SessionAccept (ex. HttpSessionAccept) is
designed to
+
+ - Check IPAllow policy
+ - Create ClientSession
+ - Pass NetVC and MIOBuffer by call ClientSession::new_connection()
+
+ NULL mutex:
+
+ - One specific protocol has ONLY one inherited class of SessionAccept.
+
+ - The object of this class is shared by all incoming request / NetVC
that
+ identified as the protocol by ProtocolSessionProbe.
+
+ - The inherited class of SessionAccept is non-blocked to allow
parellel accepts
+
+ To implement a inherited class of SessionAccept:
+
+ - No state is recorded by the handler
+
+ - Values are required to be set during construction and never changed
+
+ - Can not put into EventSystem.
+
+ So a NULL mutex is safe to continuation.
+*/
+
--- End diff --
@jpeach comments added, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
