[
https://issues.apache.org/jira/browse/TS-3508?focusedWorklogId=27065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27065
]
ASF GitHub Bot logged work on TS-3508:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/16 18:00
Start Date: 24/Aug/16 18:00
Worklog Time Spent: 10m
Work Description: Github user PSUdaemon commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/909#discussion_r76107280
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -102,7 +110,7 @@ struct SocketManager {
int dup(int s);
// result is the fd or -errno
- int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
+ int accept4(int s, struct sockaddr *addr, socklen_t *addrlen, int flags
= 0);
--- End diff --
I was on the fence about this. I went with the new name because we have a
lot of `accept()` functions floating around and I wanted the change to be
clear. Also, since we are bringing in the new API by emulating `accept4()` on
platforms where it didn't exist, I figured the name change made sense. Do any
others have an opinion about this? @jpeach? @zwoop?
Issue Time Tracking
-------------------
Worklog Id: (was: 27065)
Time Spent: 2h 40m (was: 2.5h)
> Use accept4 on linux systems where available to reduce system calls
> -------------------------------------------------------------------
>
> Key: TS-3508
> URL: https://issues.apache.org/jira/browse/TS-3508
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Reporter: John Plevyak
> Assignee: Phil Sorber
> Fix For: 7.0.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The accept4() syscall can set flags on the accepted socket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
