[
https://issues.apache.org/jira/browse/TS-3508?focusedWorklogId=27218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27218
]
ASF GitHub Bot logged work on TS-3508:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/16 04:09
Start Date: 26/Aug/16 04:09
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/909#discussion_r76361930
--- Diff: iocore/eventsystem/P_UnixSocketManager.h ---
@@ -55,21 +55,52 @@ transient_error()
return transient;
}
+#if !HAVE_ACCEPT4
+int
+accept4(int sockfd, struct sockaddr *addr, socklen_t *addrlen, int flags)
+{
+ int fd, err;
--- End diff --
Unfortunately ``ats_scoped_fd`` won't preserve errno. The ``SocketManager``
routines are inconsistent about whether they return the error or set ``errno``.
If you can clean than up (separately?) then ``ats_scoped_fd`` is a good option.
Issue Time Tracking
-------------------
Worklog Id: (was: 27218)
Time Spent: 2h 50m (was: 2h 40m)
> Use accept4 on linux systems where available to reduce system calls
> -------------------------------------------------------------------
>
> Key: TS-3508
> URL: https://issues.apache.org/jira/browse/TS-3508
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Reporter: John Plevyak
> Assignee: Phil Sorber
> Fix For: 7.0.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The accept4() syscall can set flags on the accepted socket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
