[
https://issues.apache.org/jira/browse/TS-3508?focusedWorklogId=27220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27220
]
ASF GitHub Bot logged work on TS-3508:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/16 04:12
Start Date: 26/Aug/16 04:12
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/909#discussion_r76362179
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -37,6 +37,14 @@
#include "I_EventSystem.h"
#include "I_Thread.h"
+#ifndef SOCK_NONBLOCK
+#define SOCK_NONBLOCK O_NONBLOCK
+#endif
+
+#ifndef SOCK_CLOEXEC
+#define SOCK_CLOEXEC O_CLOEXEC
--- End diff --
Pretty sure OS X doesn't have ``O_CLOEXEC``. Also the ``eventfd`` code uses
``FD_CLOEXEC`` where ``O_CLOEXEC`` would be more correct.
Issue Time Tracking
-------------------
Worklog Id: (was: 27220)
Time Spent: 3h 10m (was: 3h)
> Use accept4 on linux systems where available to reduce system calls
> -------------------------------------------------------------------
>
> Key: TS-3508
> URL: https://issues.apache.org/jira/browse/TS-3508
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Reporter: John Plevyak
> Assignee: Phil Sorber
> Fix For: 7.0.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The accept4() syscall can set flags on the accepted socket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
