Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78410788
--- Diff: proxy/http/HttpSM.cc ---
@@ -7940,3 +7940,50 @@ HttpSM::is_redirect_required()
}
return redirect_required;
}
+
+// Fill in the client protocols used. Return the number of entries
returned
+int
+HttpSM::populate_client_protocol(const char **result, int n) const
+{
+ int retval = 0;
+ if (n > 0) {
+ const char *proto =
HttpSM::find_proto_string(t_state.hdr_info.client_request.version_get());
+ if (proto) {
+ result[0] = proto;
+ retval = 1;
+ if (n > 1 && ua_session) {
--- End diff --
I'd use `retval` instead of the hard coded `1` just to be consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
