Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1007#discussion_r78411573
  
    --- Diff: proxy/http2/Http2ClientSession.h ---
    @@ -243,6 +243,32 @@ class Http2ClientSession : public ProxyClientSession
         return "http/2";
       }
     
    +  virtual int
    +  populate_protocol(char const **result, int size) const
    +  {
    +    int retval = 0;
    +    if (size > 0) {
    +      result[0] = TS_PROTO_TAG_HTTP_2_0;
    +      retval    = 1;
    +      if (size > 1) {
    +        retval += super::populate_protocol(result + 1, size - 1);
    +      }
    +    }
    +    return retval;
    +  }
    --- End diff --
    
    Could you add a newline here (and in other places between functions) please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to