Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1007#discussion_r78411137
  
    --- Diff: proxy/api/ts/ts.h ---
    @@ -2419,6 +2419,16 @@ tsapi const TSUuid TSProcessUuidGet(void);
     */
     tsapi const char *TSHttpTxnPluginTagGet(TSHttpTxn txnp);
     
    +/*
    + * Return information about the client protocols
    + */
    +tsapi TSReturnCode TSHttpTxnClientProtocolStackGet(TSHttpTxn txnp, int n, 
char const **result, int *actual);
    +tsapi TSReturnCode TSHttpSsnClientProtocolStackGet(TSHttpSsn ssnp, int n, 
char const **result, int *actual);
    +tsapi int TSHttpTxnClientProtocolStackContains(TSHttpTxn txnp, char const 
*tag, char const **ret_tag);
    +tsapi int TSHttpSsnClientProtocolStackContains(TSHttpSsn ssnp, char const 
*tag, char const **ret_tag);
    +tsapi char const *TSNormalizedProtocolTag(char const *tag);
    +tsapi char const *TSRegisterProtocolTag(char const *tag);
    --- End diff --
    
    Can we please be consistent about ``const char`` and ``char const``? Let's 
choose one or the other and file a separate Jira to make the API consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to