[
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30713
]
ASF GitHub Bot logged work on TS-4971:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/16 15:56
Start Date: 15/Oct/16 15:56
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1110#discussion_r83534526
--- Diff: plugins/authproxy/authproxy.cc ---
@@ -682,10 +682,10 @@ AuthParseOptions(int argc, const char **argv)
// on some platforms (e.g. Solaris / Illumos). On sane platforms (e.g.
linux), it'll get
// automatically casted back to the const char*, as the struct is
defined in <getopt.h>.
static const struct option longopt[] = {
- {const_cast<char *>("auth-host"), required_argument, 0, 'h'},
- {const_cast<char *>("auth-port"), required_argument, 0, 'p'},
- {const_cast<char *>("auth-transform"), required_argument, 0, 't'},
- {const_cast<char *>("force-cacheability"), no_argument, 0, 'c'},
+ {"auth-host", required_argument, 0, 'h'},
+ {"auth-port", required_argument, 0, 'p'},
+ {"auth-transform", required_argument, 0, 't'},
+ {"force-cacheability", no_argument, 0, 'c'},
--- End diff --
This change will break Solaris.
Issue Time Tracking
-------------------
Worklog Id: (was: 30713)
Time Spent: 2h 40m (was: 2.5h)
> Change TSPluginRegistration and TSPluginRegister to take const data
> -------------------------------------------------------------------
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad
> programming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
