[
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30712&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30712
]
ASF GitHub Bot logged work on TS-4971:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/16 15:56
Start Date: 15/Oct/16 15:56
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1110#discussion_r83534567
--- Diff: plugins/esi/fetcher/HttpDataFetcherImpl.cc ---
@@ -80,7 +80,7 @@ HttpDataFetcherImpl::addFetchRequest(const string &url,
FetchedDataProcessor *ca
if (length < (int)sizeof(buff)) {
http_req = buff;
} else {
- http_req = (char *)malloc(length + 1);
+ http_req = static_cast<char *>(malloc(length + 1));
--- End diff --
I'm not convinced by ``static_cast`` on ``malloc()``. It does nothing but
look uglier. It would be better not to include so many different changes in
this PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 30712)
Time Spent: 2h 40m (was: 2.5h)
> Change TSPluginRegistration and TSPluginRegister to take const data
> -------------------------------------------------------------------
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad
> programming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
