[ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30711&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30711
 ]

ASF GitHub Bot logged work on TS-4971:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Oct/16 15:56
            Start Date: 15/Oct/16 15:56
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1110#discussion_r83534537
  
    --- Diff: plugins/background_fetch/background_fetch.cc ---
    @@ -551,13 +551,12 @@ void
     TSPluginInit(int argc, const char *argv[])
     {
       TSPluginRegistrationInfo info;
    -  static const struct option longopt[] = {{const_cast<char *>("log"), 
required_argument, NULL, 'l'},
    -                                          {const_cast<char *>("config"), 
required_argument, NULL, 'c'},
    -                                          {NULL, no_argument, NULL, '\0'}};
    +  static const struct option longopt[] = {
    +    {"log", required_argument, NULL, 'l'}, {"config", required_argument, 
NULL, 'c'}, {NULL, no_argument, NULL, '\0'}};
    --- End diff --
    
    Solaris again :(


Issue Time Tracking
-------------------

    Worklog Id:     (was: 30711)
    Time Spent: 2h 40m  (was: 2.5h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> -------------------------------------------------------------------
>
>                 Key: TS-4971
>                 URL: https://issues.apache.org/jira/browse/TS-4971
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Plugins
>            Reporter: Alan M. Carroll
>             Fix For: 7.1.0
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to