[
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30746
]
ASF GitHub Bot logged work on TS-4971:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/16 15:24
Start Date: 17/Oct/16 15:24
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1114#discussion_r83667891
--- Diff: plugins/experimental/mysql_remap/mysql_remap.cc ---
@@ -232,7 +232,7 @@ TSPluginInit(int argc, const char *argv[])
return;
}
- data->query = (char *)TSmalloc(QSIZE * sizeof(char)); // TODO: malloc
smarter sizes
+ data->query = TSmalloc(QSIZE * sizeof(char)); // TODO: malloc smarter
sizes
--- End diff --
Why no ``static_cast`` here?
Issue Time Tracking
-------------------
Worklog Id: (was: 30746)
Time Spent: 4h (was: 3h 50m)
> Change TSPluginRegistration and TSPluginRegister to take const data
> -------------------------------------------------------------------
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad
> programming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
