[ https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30748 ]
ASF GitHub Bot logged work on TS-4971: -------------------------------------- Author: ASF GitHub Bot Created on: 17/Oct/16 15:24 Start Date: 17/Oct/16 15:24 Worklog Time Spent: 10m Work Description: Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1114#discussion_r83665565 --- Diff: plugins/experimental/ats_pagespeed/gzip/misc.cc --- @@ -157,7 +157,7 @@ register_plugin() const char * load_dictionary(const char *preload_file) { - char *dict = (char *)malloc(800000); + char *dict = malloc(800000); --- End diff -- This hard-coded size seems a bit optimistic. Issue Time Tracking ------------------- Worklog Id: (was: 30748) Time Spent: 4h (was: 3h 50m) > Change TSPluginRegistration and TSPluginRegister to take const data > ------------------------------------------------------------------- > > Key: TS-4971 > URL: https://issues.apache.org/jira/browse/TS-4971 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins > Reporter: Alan M. Carroll > Fix For: 7.1.0 > > Time Spent: 4h > Remaining Estimate: 0h > > These should be constant. The fact they are not causes problems and bad > programming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)