[
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30747
]
ASF GitHub Bot logged work on TS-4971:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/16 15:24
Start Date: 17/Oct/16 15:24
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1114#discussion_r83665134
--- Diff: example/intercept/intercept.cc ---
@@ -538,9 +538,9 @@ TSPluginInit(int /* argc */, const char * /* argv */ [])
{
TSPluginRegistrationInfo info;
- info.plugin_name = (char *)PLUGIN;
- info.vendor_name = (char *)"MyCompany";
- info.support_email = (char *)"[email protected]";
+ info.plugin_name = PLUGIN;
+ info.vendor_name = "MyCompany";
+ info.support_email = "[email protected]";
--- End diff --
Since you are changing all these, what do you think about standardizing on:
```C
info.plugin_name = PLUGIN_NAME;
info.vendor_name = "Apache Software Foundation";
info.support_email = "[email protected]";
```
Issue Time Tracking
-------------------
Worklog Id: (was: 30747)
Time Spent: 4h (was: 3h 50m)
> Change TSPluginRegistration and TSPluginRegister to take const data
> -------------------------------------------------------------------
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad
> programming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
