[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331064#comment-16331064
]
ASF GitHub Bot commented on TRAFODION-2873:
-------------------------------------------
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162448037
--- Diff: core/sql/exp/ExpLOBaccess.h ---
@@ -589,7 +589,7 @@ class ExLobGlobals
{
public :
- ExLobGlobals();
+ ExLobGlobals(NAHeap *lobHeap=NULL);
--- End diff --
Yes this was only done to be able to compile the call in ExpLobProcess.cpp.
Currently this code is unused and is kept around in case we need to offload any
processing to another process. This code, invokes LobGlobals and there is no
heap available. So I had to make it default just for this unused code. WIll
put a comment that it shoudl always pass a heap. In anycase a caller cannot
initialize the LobGlobals without passing in a caller's heap - i.e the only way
to initialize is by calling ExpLOBinterfaceInit or ExpLOBoper::initLobGlobal.
Both require a heap to get passed in.
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---------------------------------------------------------------
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
> Affects Versions: 2.3
> Reporter: Sandhya Sundaresan
> Assignee: Sandhya Sundaresan
> Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
