[
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331772#comment-16331772
]
ASF GitHub Bot commented on TRAFODION-2873:
-------------------------------------------
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1405#discussion_r162542021
--- Diff: core/sql/exp/ExpLOBprocess.cpp ---
@@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[])
// setup log4cxx
QRLogger::initLog4cxx(QRLogger::QRL_LOB);
// initialize lob globals
- lobGlobals = new ExLobGlobals();
+ lobGlobals = new ExLobGlobals(NULL);
--- End diff --
Thanks for avoiding the default value for the param. But, I think sending
heap as NULL might make this program to fail. Have you tested this program? If
you have tested this program already, then this PR is ready to be merged.
> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---------------------------------------------------------------
>
> Key: TRAFODION-2873
> URL: https://issues.apache.org/jira/browse/TRAFODION-2873
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
> Affects Versions: 2.3
> Reporter: Sandhya Sundaresan
> Assignee: Sandhya Sundaresan
> Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was
> an operator initially designed to operate at the disk level. It is no longer
> needed/relevant so cleaning up that code and simplifying the LOBGlobals
> sturcture as well to keep only the relevant data members.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
