[ 
https://issues.apache.org/jira/browse/TRAFODION-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331373#comment-16331373
 ] 

ASF GitHub Bot commented on TRAFODION-2873:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1405#discussion_r162492113
  
    --- Diff: core/sql/cli/Cli.cpp ---
    @@ -9611,12 +9611,28 @@ Lng32 SQLCLI_LOBddlInterface
            
          } // for
     
    +        //Initialize LOB interface 
    +        
    +        Int32 rc= 
ExpLOBoper::initLOBglobal(exLobGlob,currContext.exHeap(),&currContext,hdfsServer,hdfsPort);
    +        if (rc)
    +          {
    +            {
    --- End diff --
    
    It doesn't hurt anything, but I'm curious: Why two sets of braces? Looks 
like one would do?


> LOB:Cleanup usage of LOBLoad which si deprecated and LobGlobals
> ---------------------------------------------------------------
>
>                 Key: TRAFODION-2873
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2873
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: sql-exe
>    Affects Versions: 2.3
>            Reporter: Sandhya Sundaresan
>            Assignee: Sandhya Sundaresan
>            Priority: Major
>
> The LOBGlobals structure contains information relevant to LOBLoad which was 
> an operator initially designed to operate at the disk level. It is no longer 
> needed/relevant so cleaning up that code and simplifying the LOBGlobals 
> sturcture as well to keep only the relevant data members. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to