[
https://issues.apache.org/jira/browse/TRAFODION-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646107#comment-15646107
]
ASF GitHub Bot commented on TRAFODION-2270:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/795#discussion_r86907405
--- Diff: core/sql/optimizer/OptPhysRelExpr.cpp ---
@@ -11814,10 +11814,22 @@ void
SortGroupBy::addArrangementAndOrderRequirements(
{
// Shouldn't/Can't add a sort order type requirement
// if we are in DP2
- if (rg.getStartRequirements()->executeInDP2())
- rg.addArrangement(groupExpr(),NO_SOT);
- else
- rg.addArrangement(groupExpr(),ESP_SOT);
+
+ if( NOT extraOrderExpr().isEmpty())
+ {
+ ValueIdList groupExprCpy(groupExpr());
+ for (CollIndex i=0; i< extraOrderExpr().entries(); i++)
--- End diff --
Instead of this for loop, I think you can just do a single statement:
`groupExprCpy.insert(extraOrderExpr());`
> support ORDER BY clause in GROUP_CONCAT function
> ------------------------------------------------
>
> Key: TRAFODION-2270
> URL: https://issues.apache.org/jira/browse/TRAFODION-2270
> Project: Apache Trafodion
> Issue Type: Sub-task
> Reporter: liu ming
> Assignee: liu ming
>
> currently, GROUP_CONCAT() in Trafodion cannot recognize order by clause, need
> to support it.
> for example:
> SELECT student_name,
> GROUP_CONCAT(DISTINCT test_score
> ORDER BY test_score asc SEPARATOR ' ')
> FROM student
> GROUP BY student_name;
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
