[
https://issues.apache.org/jira/browse/TRAFODION-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646167#comment-15646167
]
ASF GitHub Bot commented on TRAFODION-2270:
-------------------------------------------
Github user traflm commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/795#discussion_r86910814
--- Diff: core/sql/optimizer/RelGrby.h ---
@@ -152,6 +154,9 @@ class GroupByAgg : public RelExpr
inline void setGroupExpr(ValueIdSet &expr) { groupExpr_ = expr;}
inline void addGroupExpr(ValueIdSet &expr) { groupExpr_ += expr;}
+ inline ValueIdList & extraOrderExpr() { return extraOrderExpr_; }
--- End diff --
Yes, it is not a good practice. I need this since this valueID list will be
populated (write) by convertToValueIdList(). Maybe I can rename this to
extraOrderExprWritable(), So the extraOrderExpr() will not be accidentally
written.
> support ORDER BY clause in GROUP_CONCAT function
> ------------------------------------------------
>
> Key: TRAFODION-2270
> URL: https://issues.apache.org/jira/browse/TRAFODION-2270
> Project: Apache Trafodion
> Issue Type: Sub-task
> Reporter: liu ming
> Assignee: liu ming
>
> currently, GROUP_CONCAT() in Trafodion cannot recognize order by clause, need
> to support it.
> for example:
> SELECT student_name,
> GROUP_CONCAT(DISTINCT test_score
> ORDER BY test_score asc SEPARATOR ' ')
> FROM student
> GROUP BY student_name;
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
