[ 
https://issues.apache.org/jira/browse/TRAFODION-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646106#comment-15646106
 ] 

ASF GitHub Bot commented on TRAFODION-2270:
-------------------------------------------

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/795#discussion_r86908390
  
    --- Diff: core/sql/optimizer/RelGrby.h ---
    @@ -552,7 +560,9 @@ class GroupByAgg : public RelExpr
       // ---------------------------------------------------------------------
       ItemExpr    * groupExprTree_;
       ValueIdSet  groupExpr_;
    -
    +  
    +  ItemExpr  * extraGrpOrderby_;
    +  ValueIdList  extraOrderExpr_;
    --- End diff --
    
    Anoop added the rollup feature recently, see 
https://github.com/apache/incubator-trafodion/pull/733. This also introduces an 
extra order by expression for a groupby. Maybe you and Anoop can decide whether 
you want to combine your code, for example by using this extra order for the 
ROLLUP groupby as well.


> support ORDER BY clause in GROUP_CONCAT function
> ------------------------------------------------
>
>                 Key: TRAFODION-2270
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2270
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>            Reporter: liu ming
>            Assignee: liu ming
>
> currently, GROUP_CONCAT() in Trafodion cannot recognize order by clause, need 
> to support it.
> for example:
> SELECT student_name,
>           GROUP_CONCAT(DISTINCT test_score
>                     ORDER BY test_score asc SEPARATOR ' ')
>           FROM student
>           GROUP BY student_name;   
>                 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to