[ 
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858762#comment-15858762
 ] 

ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r100202964
  
    --- Diff: core/sql/generator/GenRelUpdate.cpp ---
    @@ -2844,8 +2848,8 @@ short HbaseInsert::codeGen(Generator *generator)
          (noCheck()))
        hbasescan_tdb->setHbaseSqlIUD(FALSE);
     
    -      if (((getInsertType() == Insert::VSBB_INSERT_USER) && 
    -                   generator->oltOptInfo()->multipleRowsReturned()) ||
    +      if (((((getInsertType() == Insert::VSBB_INSERT_USER) || isUpsert() 
)&& 
    +           generator->oltOptInfo()->multipleRowsReturned())) ||
    --- End diff --
    
    A nit, there is an unnecessary pair of parentheses at the beginning of line 
2851 and the end of line 2852.


> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
>                 Key: TRAFODION-1562
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1562
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: sql-cmp
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Sandhya Sundaresan
>         Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to