[ 
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858155#comment-15858155
 ] 

ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------

Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r100099385
  
    --- Diff: core/sql/regress/executor/EXPECTED015.SB ---
    @@ -1961,51 +1970,51 @@ TRAFODION_MERGE
     +>(select d.id from DEC1 d where d.codeValue = ?),  ? ) ;
     
     --- SQL command prepared.
    ->>execute explainIt;
    +>>execute explainItEff;
     
     OPERATOR        
     ----------------
     
    -TRAFODION_MERGE 
    +SEQUENCE        
     
     --- 1 row(s) selected.
     >>
     >>prepare XX from UPSERT INTO DE (ID, dataElementConceptID, valueDomainID) 
 
     +>VALUES  (1,  (select d.id from DEC1 d where d.codeValue = ?),  3 ) ;
     
     --- SQL command prepared.
    ->>execute explainIt;
    +>>execute explainItEff;
     
     OPERATOR        
     ----------------
     
    -TRAFODION_MERGE 
    +SEQUENCE        
     
     --- 1 row(s) selected.
     >>
     >>prepare XX from UPSERT INTO DE (ID, dataElementConceptID, valueDomainID) 
 
     +>VALUES  (?[10], ?[10], ?[10] ) ;
     
     --- SQL command prepared.
    ->>execute explainIt;
    +>>execute explainItEff;
     
     OPERATOR        
     ----------------
     
    -TRAFODION_MERGE 
    +SEQUENCE        
    --- End diff --
    
    Test cases are nice and robust. I like them.


> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
>                 Key: TRAFODION-1562
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1562
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: sql-cmp
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Sandhya Sundaresan
>         Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to