[
https://issues.apache.org/jira/browse/TRAFODION-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858355#comment-15858355
]
ASF GitHub Bot commented on TRAFODION-1562:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/946#discussion_r100134813
--- Diff: core/sql/executor/ExHbaseIUD.cpp ---
@@ -1620,21 +1685,20 @@ ExWorkProcRetcode
ExHbaseAccessBulkLoadPrepSQTcb::work()
{
if (qparent_.up->isFull())
return WORK_OK;
-
+
if (returnUpdateExpr())
{
- ex_queue_entry * up_entry = qparent_.up->getTailEntry();
-
- // allocate tupps where returned rows will be created
- if (allocateUpEntryTupps(
- -1,
- 0,
- hbaseAccessTdb().returnedTuppIndex_,
- hbaseAccessTdb().returnUpdatedRowLen_,
- FALSE,
- &rc))
+ ex_queue_entry * up_entry = qparent_.up->getTailEntry();
return rc;
-
+ // allocate tupps where returned rows will be created
+ if (allocateUpEntryTupps(
+ -1,
+ 0,
+ hbaseAccessTdb().returnedTuppIndex_,
+ hbaseAccessTdb().returnUpdatedRowLen_,
+ FALSE,
+ &rc))
+ return 1;
--- End diff --
Should this be return rc?
> Changes in query tree when the upsert command is transformed into merge
> -----------------------------------------------------------------------
>
> Key: TRAFODION-1562
> URL: https://issues.apache.org/jira/browse/TRAFODION-1562
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Reporter: Selvaganesan Govindarajan
> Assignee: Sandhya Sundaresan
> Attachments: BatchUpsertTransformation.pdf
>
>
> to improve the performance as explained in the main JIRA
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
