[
https://issues.apache.org/jira/browse/TRAFODION-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021010#comment-16021010
]
ASF GitHub Bot commented on TRAFODION-2385:
-------------------------------------------
Github user xwq commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1098#discussion_r117954467
--- Diff:
core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/InterfaceStatement.java ---
@@ -671,6 +683,11 @@ void convertObjectToSQL2(Locale locale,
TrafT4Statement pstmt, Object paramValue
byte[] b =
InterfaceUtilities.convertBigDecimalToSQLBigNum(tmpbd, maxLength, scale);
System.arraycopy(b, 0, values, noNullValue, maxLength);
break;
+ case InterfaceResultSet.SQLTYPECODE_BOOLEAN:
+ tmpbd = Utility.getBigDecimalValue(locale, paramValue);
+
+ Bytes.insertShort(values, noNullValue,
tmpbd.shortValue(), this.ic_.getByteSwap());
--- End diff --
Why we need 2 bytes for BOOLEAN, do you compare the maxlength_ with it.
> Add support in clients for boolean, tinyint, largeint unsigned datatypes
> ------------------------------------------------------------------------
>
> Key: TRAFODION-2385
> URL: https://issues.apache.org/jira/browse/TRAFODION-2385
> Project: Apache Trafodion
> Issue Type: New Feature
> Components: connectivity-general
> Reporter: Anoop Sharma
> Fix For: 2.1-incubating
>
>
> Support for new datatypes was added for tinyint, boolean, largeint unsigned
> in sql engine.
> Those are tracked by following jiras:
> JIRA TRAFODION-2086 Add support for largeint unsigned datatype
> JIRA TRAFODION-2099 Add support for Boolean datatype
> JIRA TRAFODION-2060 Add support for native tinyint datatype
> Connectivity clients (odbc, jdbc t2/t4, linux, windows, trafci) need to
> enhanced to add this support. There may also be some work needed
> in mxosrvr layer. Until that is done, these datatypes cannot be used
> for reading values or input params from these clients.
> For now, these datatypes are converted to equivalent datatypes before
> input/output from clients.
> To enable these datatypes, use these cqds:
> For tinyint:
> cqd traf_tinyint_return_values 'ON';
> cqd traf_tinyint_input_params 'ON';
>
> For boolean:
> cqd traf_boolean_io 'ON';
> For unsigned largeint:
> cqd traf_largeint_unsigned_io 'ON';
> These cqds are turned ON when request comes in from sqlci.
> Once support for these datatypes is added to clients, they will be turned
> on by default.
> core/sql/regress/seabase/TEST003 contains examples of usage of these
> datatypes. First cut should be to make sure they work from trafci/jdbcT4.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
