[
https://issues.apache.org/jira/browse/TRAFODION-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021500#comment-16021500
]
ASF GitHub Bot commented on TRAFODION-2385:
-------------------------------------------
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1098#discussion_r118051474
--- Diff:
core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4PreparedStatement.java
---
@@ -1051,10 +1054,29 @@ public void setLong(int parameterIndex, long x)
throws SQLException {
}
validateSetInvocation(parameterIndex);
inputDesc_[parameterIndex -
1].checkValidNumericConversion(connection_.getLocale());
- Utility.checkLongBoundary(connection_.getLocale(),
BigDecimal.valueOf(x));
addParamValue(parameterIndex, Long.toString(x));
}
+ private void setLong(int parameterIndex, BigDecimal x) throws
SQLException {
+ if (connection_.props_.t4Logger_.isLoggable(Level.FINE) ==
true) {
+ Object p[] =
T4LoggingUtilities.makeParams(connection_.props_, parameterIndex, x);
+ connection_.props_.t4Logger_.logp(Level.FINE,
"TrafT4PreparedStatement", "setLong", "", p);
+ }
+ if (connection_.props_.getLogWriter() != null) {
+ LogRecord lr = new LogRecord(Level.FINE, "");
--- End diff --
Looks like all these statements will be executed and the objects created,
but thrown away because the level is not set to FINE. Or in other words when
will be the getLogWriter() be NULL?
> Add support in clients for boolean, tinyint, largeint unsigned datatypes
> ------------------------------------------------------------------------
>
> Key: TRAFODION-2385
> URL: https://issues.apache.org/jira/browse/TRAFODION-2385
> Project: Apache Trafodion
> Issue Type: New Feature
> Components: connectivity-general
> Reporter: Anoop Sharma
> Fix For: 2.1-incubating
>
>
> Support for new datatypes was added for tinyint, boolean, largeint unsigned
> in sql engine.
> Those are tracked by following jiras:
> JIRA TRAFODION-2086 Add support for largeint unsigned datatype
> JIRA TRAFODION-2099 Add support for Boolean datatype
> JIRA TRAFODION-2060 Add support for native tinyint datatype
> Connectivity clients (odbc, jdbc t2/t4, linux, windows, trafci) need to
> enhanced to add this support. There may also be some work needed
> in mxosrvr layer. Until that is done, these datatypes cannot be used
> for reading values or input params from these clients.
> For now, these datatypes are converted to equivalent datatypes before
> input/output from clients.
> To enable these datatypes, use these cqds:
> For tinyint:
> cqd traf_tinyint_return_values 'ON';
> cqd traf_tinyint_input_params 'ON';
>
> For boolean:
> cqd traf_boolean_io 'ON';
> For unsigned largeint:
> cqd traf_largeint_unsigned_io 'ON';
> These cqds are turned ON when request comes in from sqlci.
> Once support for these datatypes is added to clients, they will be turned
> on by default.
> core/sql/regress/seabase/TEST003 contains examples of usage of these
> datatypes. First cut should be to make sure they work from trafci/jdbcT4.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
