[ 
https://issues.apache.org/jira/browse/TRAFODION-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271956#comment-16271956
 ] 

ASF GitHub Bot commented on TRAFODION-2731:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1317#discussion_r153962963
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -547,40 +538,29 @@ SDDkwd__(CAT_ENABLE_QUERY_INVALIDATION, "ON"),
     // If DB Limits is enabled, then increase the default blocksize to 32K
     // on NSK if the object's clustering key length is larger than this value.
     
    -  DDui1__(CAT_LARGE_BLOCKS_MAX_KEYSIZE,   "1"),
     
     // If DB Limits is enabled, then increase the default blocksize to 32K
     // on NSK if the object's row size is larger than this value.
     
    -  DDui1__(CAT_LARGE_BLOCKS_MAX_ROWSIZE,   "1"),
     
     // Controls how pathnames for routines/procedures/SPJs are interpreted
       DDkwd__(CAT_LIBRARY_PATH_RELATIVE, "OFF"),
     
    -  DDkwd__(CAT_MORE_SCHEMA_PRIVS, "ON"),
     
    -  DDkwd__(CAT_OVERRIDE_CREATE_DISABLE, "OFF"),
     
     
     // This forces an rcb to be created with a different version number
     // A "0" means to take the current mxv version
    --- End diff --
    
    And in numerous additional places


> CodeCleanup: Remove obsolete, legacy and unused code
> ----------------------------------------------------
>
>                 Key: TRAFODION-2731
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2731
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: Anoop Sharma
>            Assignee: Anoop Sharma
>            Priority: Minor
>
> There is code in trafodion branch that is leftover from previous product and
> is no longer used.  
> It includes legacy features and code fragments, unneeded ifdef defines and 
> obsolete files.
> Having all that old code makes it difficult to read, understand or make 
> changes.
> This jira is filed to handle removal of obsolete code.
> It will be implemented in multiple phases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to