[ 
https://issues.apache.org/jira/browse/TRAFODION-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271957#comment-16271957
 ] 

ASF GitHub Bot commented on TRAFODION-2731:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1317#discussion_r153962829
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -523,20 +520,14 @@ SDDkwd__(CAT_ENABLE_QUERY_INVALIDATION, "ON"),
     
      // Throw an error if a column is part of the store by clause and
      // is not defined as NOT NULL return an error
    - DDkwd__(CAT_ERROR_ON_NOTNULL_STOREBY, "ON"),
     
    - DDui1__(CAT_FS_TIMEOUT,                       "9000"),
     
      // Used to make ignore "already exists" error in Create and
      // "does not exist" error in Drop.
    - DDkwd__(CAT_IGNORE_ALREADY_EXISTS_ERROR, "OFF"),
    - DDkwd__(CAT_IGNORE_DOES_NOT_EXIST_ERROR, "OFF"),
     
      // Used to make catman test134 predictable
    - DDkwd__(CAT_IGNORE_EMPTY_CATALOGS, "OFF"),
     
      // Catalog Manager internal support for REPLICATE AUTHORIZATION
    --- End diff --
    
    And here


> CodeCleanup: Remove obsolete, legacy and unused code
> ----------------------------------------------------
>
>                 Key: TRAFODION-2731
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2731
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: Anoop Sharma
>            Assignee: Anoop Sharma
>            Priority: Minor
>
> There is code in trafodion branch that is leftover from previous product and
> is no longer used.  
> It includes legacy features and code fragments, unneeded ifdef defines and 
> obsolete files.
> Having all that old code makes it difficult to read, understand or make 
> changes.
> This jira is filed to handle removal of obsolete code.
> It will be implemented in multiple phases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to