jerqi commented on PR #53: URL: https://github.com/apache/incubator-uniffle/pull/53#issuecomment-1212791890
> The changed first commit: [52c53d5](https://github.com/apache/incubator-uniffle/commit/52c53d513c494990ad2d9e2ad3b56584e9473ea8) > > Changelog: > > 1. Introduce the `SecurityContextFactory` to manage security. > 2. In `HadoopSecurityContext`, it will do kerberos login and refresh auth. The `hadoopSecurityContext` will only be initialized when kerberos security is enabled. Default securityContext is `NoOpSecurityContext`. > 3. `HadoopFileSystemProvider` will be a static class for invoking. > > This commit make the security and filesystem retrieval separate. > > Could u help review it? @jerqi @colinmjj And I will submit commits one by one in next days. I have left some comments. General code is ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
