zuston commented on code in PR #53:
URL: https://github.com/apache/incubator-uniffle/pull/53#discussion_r945566596
##########
server/src/main/java/org/apache/uniffle/server/storage/StorageManager.java:
##########
@@ -45,9 +45,11 @@ public interface StorageManager {
void stop();
- void registerRemoteStorage(String appId, RemoteStorageInfo
remoteStorageInfo);
+ void registerRemoteStorage(String appId, RemoteStorageInfo
remoteStorageInfo, String user);
Review Comment:
If storing in shuffleTaskManager, there is no chance to get it when creating
writer handler in ShuffleFlushManager.
The writer handler is trigger by the shuffleDataFlushEvent created by
ShuffleBufferManager. There are 2 ways to solve
1. Store the appId -> user into ShuffleBufferManager
2. Make the ShuffleTaskManager as a member of ShuffleBufferManager, and then
the invoking like this
`shuffleBufferManager.getShuffleTaskManager.getUserByAppId()`
What do u think @colinmjj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
