jerqi commented on PR #53: URL: https://github.com/apache/incubator-uniffle/pull/53#issuecomment-1214540938
> > 2. Add an api in Storage to check if it is secured, eg, isSecuredStorage() > > 3. Create new writeHandler/readHandler to deal with secured write/read, eg, SecuredHdfsShuffleWriteHandler extends HdfsShuffleWriteHandler > > I think there is no need to introduce extra secured method and writer handler for security. > > All the secured operation can be handled by filesystem. And the difference of secured and no-secured fs is the way of initialization which will be handled by HadoopFilesystemProvider [52c53d5](https://github.com/apache/incubator-uniffle/commit/52c53d513c494990ad2d9e2ad3b56584e9473ea8) > > Please let me what you think @jerqi @colinmjj . Thanks LGTM, cc @colinmjj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
