xianjingfeng commented on code in PR #276:
URL: https://github.com/apache/incubator-uniffle/pull/276#discussion_r1003949297
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleReadClientImpl.java:
##########
@@ -60,6 +60,8 @@ public class ShuffleReadClientImpl implements
ShuffleReadClient {
private AtomicLong crcCheckTime = new AtomicLong(0);
private ClientReadHandler clientReadHandler;
private final IdHelper idHelper;
+ private int fallbackTimes;
+ private int maxFallbackTimes = 3;
Review Comment:
Most jobs can run successfully without fallback mechanism, so it think 3 is
enough. And it's difficult to pass parameters in the client. Should we add an
new configration class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
