xianjingfeng commented on code in PR #276:
URL: https://github.com/apache/incubator-uniffle/pull/276#discussion_r1003959454
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/MemoryQuorumClientReadHandler.java:
##########
@@ -65,11 +72,26 @@ public ShuffleDataResult readShuffleData() {
}
}
- if (!readSuccessful) {
+ if (!readSuccessful && !readAfterFallback) {
Review Comment:
Because we don't know where the missing blocks be, even if read fail from
memory after fallback, these blocks may also be complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
