smallzhongfeng commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1020743067
##########
proto/src/main/proto/Rss.proto:
##########
@@ -302,6 +302,7 @@ service CoordinatorServer {
message AppHeartBeatRequest {
string appId = 1;
+ string user = 2;
Review Comment:
If the heartbeat of the driver is used to send to the coordinator, the
implementation is simple. If the heartbeat of the shuffleServer is used, you
need to add a collection attribute in the heartbeat request of the
shuffleServer, record the user and the corresponding app list, and then
summarize them in the coordinator. Right ? And I haven't found the advantages
of doing this for the time being. At present, this pr and our current
production environment deployment have enough restrictions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
