smallzhongfeng commented on code in PR #311:
URL: https://github.com/apache/incubator-uniffle/pull/311#discussion_r1020747944
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -203,12 +206,12 @@ public RssShuffleManager(SparkConf sparkConf, boolean
isDriver) {
@Override
public <K, V, C> ShuffleHandle registerShuffle(int shuffleId, int numMaps,
ShuffleDependency<K, V, C> dependency) {
// If yarn enable retry ApplicationMaster, appId will be not unique and
shuffle data will be incorrect,
- // appId + timestamp can avoid such problem,
+ // appId + uuid can avoid such problem,
Review Comment:
Do you mean to generate the uuid on the driver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
