jerqi commented on code in PR #327:
URL: https://github.com/apache/incubator-uniffle/pull/327#discussion_r1023463430
##########
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java:
##########
@@ -119,4 +138,12 @@ public Gauge getGaugeGrpcOpen() {
public Counter getCounterGrpcTotal() {
return counterGrpcTotal;
}
+
+ public Map<String, Summary> getSendTimeSummaryMap() {
Review Comment:
What's the meaning of `sendTime`?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -186,6 +186,11 @@ public void sendShuffleData(SendShuffleDataRequest req,
String appId = req.getAppId();
int shuffleId = req.getShuffleId();
long requireBufferId = req.getRequireBufferId();
+ long sendTime = req.getSendTime();
+ if (sendTime > 0) {
+
shuffleServer.getGrpcMetrics().recordSendTime(ShuffleServerGrpcMetrics.SEND_SHUFFLE_DATA_METHOD,
Review Comment:
Do we need consider the data size when we calculate the metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
